diff options
| author | Sven Eckelmann <sven@narfation.org> | 2011-06-05 10:20:19 +0200 |
|---|---|---|
| committer | Sven Eckelmann <sven@narfation.org> | 2011-06-09 20:40:38 +0200 |
| commit | 3d222bbaa7329e8ef45129e1bd6801000d7e05e4 (patch) | |
| tree | ab6db91fb6bea05e116de52228167879e627adae /net/batman-adv | |
| parent | e72948eb21d1da0275be1c6e0c7a9a22aa67a5e3 (diff) | |
| download | lwn-3d222bbaa7329e8ef45129e1bd6801000d7e05e4.tar.gz lwn-3d222bbaa7329e8ef45129e1bd6801000d7e05e4.zip | |
batman-adv: Rewrite debugfs kobj_to_* helpers as functions
CodingStyle "Chapter 12: Macros, Enums and RTL" highly recommends to use
functions instead of macros were possible. This ensures type safety and
prevents shadowing of other variables.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Diffstat (limited to 'net/batman-adv')
| -rw-r--r-- | net/batman-adv/bat_sysfs.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/net/batman-adv/bat_sysfs.c b/net/batman-adv/bat_sysfs.c index 6f70560ef508..924d5773da21 100644 --- a/net/batman-adv/bat_sysfs.c +++ b/net/batman-adv/bat_sysfs.c @@ -28,9 +28,17 @@ #include "gateway_client.h" #include "vis.h" -#define to_dev(obj) container_of(obj, struct device, kobj) -#define kobj_to_netdev(obj) to_net_dev(to_dev(obj->parent)) -#define kobj_to_batpriv(obj) netdev_priv(kobj_to_netdev(obj)) +static struct net_device *kobj_to_netdev(struct kobject *obj) +{ + struct device *dev = container_of(obj->parent, struct device, kobj); + return to_net_dev(dev); +} + +static struct bat_priv *kobj_to_batpriv(struct kobject *obj) +{ + struct net_device *net_dev = kobj_to_netdev(obj); + return netdev_priv(net_dev); +} /* Use this, if you have customized show and store functions */ #define BAT_ATTR(_name, _mode, _show, _store) \ |