diff options
| author | Sven Eckelmann <sven@narfation.org> | 2016-02-22 21:02:39 +0100 |
|---|---|---|
| committer | Antonio Quartulli <a@unstable.cc> | 2016-05-10 18:28:54 +0800 |
| commit | 4b426b108ac82b27f5af40df7da05a2501fd2aca (patch) | |
| tree | c3dc63c67671262f1abb68fbb4dccc7adacdb3f9 /net/batman-adv/soft-interface.c | |
| parent | f0b94ebccd2b924237ca7a101da3db70c3a8f0f2 (diff) | |
| download | lwn-4b426b108ac82b27f5af40df7da05a2501fd2aca.tar.gz lwn-4b426b108ac82b27f5af40df7da05a2501fd2aca.zip | |
batman-adv: Use bool as return type for boolean functions
It is easier to understand that the returned value of a specific function
doesn't have to be 0 when the functions was successful when the actual
return type is bool. This is especially true when all surrounding functions
with return type int use negative values to return the error code.
Reported-by: Nicholas Krause <xerofoify@gmail.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net/batman-adv/soft-interface.c')
| -rw-r--r-- | net/batman-adv/soft-interface.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c index 04866c9b860a..3a0fc3c18444 100644 --- a/net/batman-adv/soft-interface.c +++ b/net/batman-adv/soft-interface.c @@ -1045,12 +1045,12 @@ static void batadv_softif_destroy_netlink(struct net_device *soft_iface, unregister_netdevice_queue(soft_iface, head); } -int batadv_softif_is_valid(const struct net_device *net_dev) +bool batadv_softif_is_valid(const struct net_device *net_dev) { if (net_dev->netdev_ops->ndo_start_xmit == batadv_interface_tx) - return 1; + return true; - return 0; + return false; } struct rtnl_link_ops batadv_link_ops __read_mostly = { |