diff options
| author | Paul Kot <pawlkt@gmail.com> | 2011-12-10 15:28:34 +0100 |
|---|---|---|
| committer | Marek Lindner <lindner_marek@yahoo.de> | 2011-12-12 19:11:06 +0800 |
| commit | c00b6856fc642b234895cfabd15b289e76726430 (patch) | |
| tree | 20ef4b559bd92bc45fe226b59c2e5111a8f18a9e /net/batman-adv/icmp_socket.c | |
| parent | 69497c17c6ffc636e463d528c2f4c87e4d894964 (diff) | |
| download | lwn-c00b6856fc642b234895cfabd15b289e76726430.tar.gz lwn-c00b6856fc642b234895cfabd15b289e76726430.zip | |
batman-adv: bat_socket_read missing checks
Writing a icmp_packet_rr and then reading icmp_packet can lead to kernel
memory corruption, if __user *buf is just below TASK_SIZE.
Signed-off-by: Paul Kot <pawlkt@gmail.com>
[sven@narfation.org: made it checkpatch clean]
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Diffstat (limited to 'net/batman-adv/icmp_socket.c')
| -rw-r--r-- | net/batman-adv/icmp_socket.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/batman-adv/icmp_socket.c b/net/batman-adv/icmp_socket.c index defd6929ceae..88ab26f5f726 100644 --- a/net/batman-adv/icmp_socket.c +++ b/net/batman-adv/icmp_socket.c @@ -136,8 +136,8 @@ static ssize_t bat_socket_read(struct file *file, char __user *buf, spin_unlock_bh(&socket_client->lock); - error = __copy_to_user(buf, &socket_packet->icmp_packet, - socket_packet->icmp_len); + error = copy_to_user(buf, &socket_packet->icmp_packet, + socket_packet->icmp_len); packet_len = socket_packet->icmp_len; kfree(socket_packet); |