diff options
| author | Adrian Bunk <bunk@kernel.org> | 2007-08-14 17:39:43 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-08-14 17:39:43 -0700 |
| commit | 16f3051b166bde3f1bd741783b64a8feebdb6f00 (patch) | |
| tree | 7f3ce2314cc2ccb2790b6c48cdd553a0aaea1bb8 /net/8021q/vlanproc.c | |
| parent | 6f93b9c28326df34b23a6c0dbe4c51d4654bdf0b (diff) | |
| download | lwn-16f3051b166bde3f1bd741783b64a8feebdb6f00.tar.gz lwn-16f3051b166bde3f1bd741783b64a8feebdb6f00.zip | |
[VLAN] net/8021q/vlanproc.c: fix check-after-use
The Coverity checker spotted that we'd have already oops'ed if
"vlandev" was NULL.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q/vlanproc.c')
| -rw-r--r-- | net/8021q/vlanproc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c index c0040c9064a1..bd08aa090763 100644 --- a/net/8021q/vlanproc.c +++ b/net/8021q/vlanproc.c @@ -319,7 +319,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset) static const char fmt[] = "%30s %12lu\n"; int i; - if ((vlandev == NULL) || (!(vlandev->priv_flags & IFF_802_1Q_VLAN))) + if (!(vlandev->priv_flags & IFF_802_1Q_VLAN)) return 0; seq_printf(seq, "%s VID: %d REORDER_HDR: %i dev->priv_flags: %hx\n", |