diff options
| author | Mark Fasheh <mark.fasheh@oracle.com> | 2007-07-19 01:47:00 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-19 10:04:41 -0700 |
| commit | 6967614761fd305b3414d9485d89dc2e0a407410 (patch) | |
| tree | 498bd41e9cf8795535f597696dd2c834d79ffb44 /mm | |
| parent | 54cb8821de07f2ffcd28c380ce9b93d5784b40d7 (diff) | |
| download | lwn-6967614761fd305b3414d9485d89dc2e0a407410.tar.gz lwn-6967614761fd305b3414d9485d89dc2e0a407410.zip | |
ocfs2: release page lock before calling ->page_mkwrite
__do_fault() was calling ->page_mkwrite() with the page lock held, which
violates the locking rules for that callback. Release and retake the page
lock around the callback to avoid deadlocking file systems which manually
take it.
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/memory.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/mm/memory.c b/mm/memory.c index eee7fec3ab54..7abd3899848b 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -2369,11 +2369,14 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma, * address space wants to know that the page is about * to become writable */ - if (vma->vm_ops->page_mkwrite && - vma->vm_ops->page_mkwrite(vma, page) < 0) { - fdata.type = VM_FAULT_SIGBUS; - anon = 1; /* no anon but release faulted_page */ - goto out; + if (vma->vm_ops->page_mkwrite) { + unlock_page(page); + if (vma->vm_ops->page_mkwrite(vma, page) < 0) { + fdata.type = VM_FAULT_SIGBUS; + anon = 1; /* no anon but release faulted_page */ + goto out_unlocked; + } + lock_page(page); } } @@ -2425,6 +2428,7 @@ static int __do_fault(struct mm_struct *mm, struct vm_area_struct *vma, out: unlock_page(faulted_page); +out_unlocked: if (anon) page_cache_release(faulted_page); else if (dirty_page) { |