diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2008-05-07 09:22:39 +0200 |
|---|---|---|
| committer | Jens Axboe <jens.axboe@oracle.com> | 2008-05-07 09:29:00 +0200 |
| commit | 7f3d4ee108c184ab215036051087aaaaa8de7661 (patch) | |
| tree | 373f4f928f0687ca84478964b43c26e3ec9cec70 /mm | |
| parent | 07416d29bcf608257f1e5280642dcbe0021518a3 (diff) | |
| download | lwn-7f3d4ee108c184ab215036051087aaaaa8de7661.tar.gz lwn-7f3d4ee108c184ab215036051087aaaaa8de7661.zip | |
vfs: splice remove_suid() cleanup
generic_file_splice_write() duplicates remove_suid() just because it
doesn't hold i_mutex. But it grabs i_mutex inside splice_from_pipe()
anyway, so this is rather pointless.
Move locking to generic_file_splice_write() and call remove_suid() and
__splice_from_pipe() instead.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/filemap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/filemap.c b/mm/filemap.c index 239d36163bbe..2dead9adf8b7 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1655,7 +1655,7 @@ int should_remove_suid(struct dentry *dentry) } EXPORT_SYMBOL(should_remove_suid); -int __remove_suid(struct dentry *dentry, int kill) +static int __remove_suid(struct dentry *dentry, int kill) { struct iattr newattrs; |