diff options
author | Colin Ian King <colin.king@canonical.com> | 2015-07-27 15:23:43 +0100 |
---|---|---|
committer | Luis Henriques <luis.henriques@canonical.com> | 2015-08-11 09:57:27 +0100 |
commit | 9bc34abfec8f083cb5ea50534d22d114ab12c4e3 (patch) | |
tree | 94de08770180ba9e51fb19e5fcf0a5ad39d13cf5 /mm | |
parent | 373f2d629bcc15ac81901dd13d3d87a2376b8c60 (diff) | |
download | lwn-9bc34abfec8f083cb5ea50534d22d114ab12c4e3.tar.gz lwn-9bc34abfec8f083cb5ea50534d22d114ab12c4e3.zip |
KEYS: ensure we free the assoc array edit if edit is valid
commit ca4da5dd1f99fe9c59f1709fb43e818b18ad20e0 upstream.
__key_link_end is not freeing the associated array edit structure
and this leads to a 512 byte memory leak each time an identical
existing key is added with add_key().
The reason the add_key() system call returns okay is that
key_create_or_update() calls __key_link_begin() before checking to see
whether it can update a key directly rather than adding/replacing - which
it turns out it can. Thus __key_link() is not called through
__key_instantiate_and_link() and __key_link_end() must cancel the edit.
CVE-2015-1333
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <james.l.morris@oracle.com>
Cc: Moritz Mühlenhoff <jmm@inutil.org>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions