diff options
| author | Peng Wang <rocking@whu.edu.cn> | 2019-03-05 15:42:00 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-03-05 21:07:14 -0800 |
| commit | edde82b6df70cf10486d7f1e1611151218e6c316 (patch) | |
| tree | 09dd072ad0753f3e0239580d5a75f909cd06d987 /mm/slub.c | |
| parent | 5704a06810682683355624923547b41540e2801a (diff) | |
| download | lwn-edde82b6df70cf10486d7f1e1611151218e6c316.tar.gz lwn-edde82b6df70cf10486d7f1e1611151218e6c316.zip | |
mm/slub.c: freelist is ensured to be NULL when new_slab() fails
new_slab_objects() will return immediately if freelist is not NULL.
if (freelist)
return freelist;
One more assignment operation could be avoided.
Link: http://lkml.kernel.org/r/20181229062512.30469-1-rocking@whu.edu.cn
Signed-off-by: Peng Wang <rocking@whu.edu.cn>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/slub.c')
| -rw-r--r-- | mm/slub.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/mm/slub.c b/mm/slub.c index dc777761b6b7..a561f909446d 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2482,8 +2482,7 @@ static inline void *new_slab_objects(struct kmem_cache *s, gfp_t flags, stat(s, ALLOC_SLAB); c->page = page; *pc = c; - } else - freelist = NULL; + } return freelist; } |