diff options
| author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2009-06-25 12:31:37 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-07-30 14:39:04 -0700 |
| commit | e9cbe5c4d29e052c38e500a06517b27c60f22c02 (patch) | |
| tree | 807b57e4d94ba9d3add4058ebc8270e5cac11a9c /mm/slub.c | |
| parent | 843f9d9fa71d3889169172b20ee07ae6e51c0be4 (diff) | |
| download | lwn-e9cbe5c4d29e052c38e500a06517b27c60f22c02.tar.gz lwn-e9cbe5c4d29e052c38e500a06517b27c60f22c02.zip | |
fix RCU-callback-after-kmem_cache_destroy problem in sl[aou]b
commit 7ed9f7e5db58c6e8c2b4b738a75d5dcd8e17aad5 upstream.
Jesper noted that kmem_cache_destroy() invokes synchronize_rcu() rather than
rcu_barrier() in the SLAB_DESTROY_BY_RCU case, which could result in RCU
callbacks accessing a kmem_cache after it had been destroyed.
Acked-by: Matt Mackall <mpm@selenic.com>
Reported-by: Jesper Dangaard Brouer <hawk@comx.dk>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'mm/slub.c')
| -rw-r--r-- | mm/slub.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/mm/slub.c b/mm/slub.c index 65ffda5934b0..253016d3cb4c 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2490,6 +2490,8 @@ static inline int kmem_cache_close(struct kmem_cache *s) */ void kmem_cache_destroy(struct kmem_cache *s) { + if (s->flags & SLAB_DESTROY_BY_RCU) + rcu_barrier(); down_write(&slub_lock); s->refcount--; if (!s->refcount) { |