diff options
| author | ye xingchen <ye.xingchen@zte.com.cn> | 2022-08-22 01:38:30 +0000 |
|---|---|---|
| committer | Vlastimil Babka <vbabka@suse.cz> | 2022-08-23 16:07:36 +0200 |
| commit | 2bfbb0271a5b48c01c711d1509a422a7244c9eb8 (patch) | |
| tree | 1d53083153a83144302aefd81dd09930aa01fc33 /mm/slub.c | |
| parent | 610f9c00ce6ed894caf9bb4feb3c026339150233 (diff) | |
| download | lwn-2bfbb0271a5b48c01c711d1509a422a7244c9eb8.tar.gz lwn-2bfbb0271a5b48c01c711d1509a422a7244c9eb8.zip | |
mm/slub: Remove the unneeded result variable
Return the value from attribute->store(s, buf, len) and
attribute->show(s, buf) directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Diffstat (limited to 'mm/slub.c')
| -rw-r--r-- | mm/slub.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/mm/slub.c b/mm/slub.c index 862dbd9af4f5..dc59b9e8c66f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5826,7 +5826,6 @@ static ssize_t slab_attr_show(struct kobject *kobj, { struct slab_attribute *attribute; struct kmem_cache *s; - int err; attribute = to_slab_attr(attr); s = to_slab(kobj); @@ -5834,9 +5833,7 @@ static ssize_t slab_attr_show(struct kobject *kobj, if (!attribute->show) return -EIO; - err = attribute->show(s, buf); - - return err; + return attribute->show(s, buf); } static ssize_t slab_attr_store(struct kobject *kobj, @@ -5845,7 +5842,6 @@ static ssize_t slab_attr_store(struct kobject *kobj, { struct slab_attribute *attribute; struct kmem_cache *s; - int err; attribute = to_slab_attr(attr); s = to_slab(kobj); @@ -5853,8 +5849,7 @@ static ssize_t slab_attr_store(struct kobject *kobj, if (!attribute->store) return -EIO; - err = attribute->store(s, buf, len); - return err; + return attribute->store(s, buf, len); } static void kmem_cache_release(struct kobject *k) |