diff options
| author | Christoph Hellwig <hch@lst.de> | 2010-05-26 17:53:41 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2010-05-27 22:06:06 -0400 |
| commit | 1b061d9247f71cd15edc4c4c4600191a903642c0 (patch) | |
| tree | 30d92ca82d8286e7a45fba108230ecd23e61673b /mm/shmem.c | |
| parent | 7ea8085910ef3dd4f3cad6845aaa2b580d39b115 (diff) | |
| download | lwn-1b061d9247f71cd15edc4c4c4600191a903642c0.tar.gz lwn-1b061d9247f71cd15edc4c4c4600191a903642c0.zip | |
rename the generic fsync implementations
We don't name our generic fsync implementations very well currently.
The no-op implementation for in-memory filesystems currently is called
simple_sync_file which doesn't make too much sense to start with,
the the generic one for simple filesystems is called simple_fsync
which can lead to some confusion.
This patch renames the generic file fsync method to generic_file_fsync
to match the other generic_file_* routines it is supposed to be used
with, and the no-op implementation to noop_fsync to make it obvious
what to expect. In addition add some documentation for both methods.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'mm/shmem.c')
| -rw-r--r-- | mm/shmem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/shmem.c b/mm/shmem.c index 855eaf5b8d5b..4daf8cecf422 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2433,7 +2433,7 @@ static const struct file_operations shmem_file_operations = { .write = do_sync_write, .aio_read = shmem_file_aio_read, .aio_write = generic_file_aio_write, - .fsync = simple_sync_file, + .fsync = noop_fsync, .splice_read = generic_file_splice_read, .splice_write = generic_file_splice_write, #endif |