diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2008-07-04 09:59:28 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-04 10:40:04 -0700 |
| commit | 7a36a752d006f6874049da510297eeb7f09d92a7 (patch) | |
| tree | 764d02c44b95e34deb9cd3ed9d7bdc03c35ef172 /mm/memory.c | |
| parent | 7ca796f492a11f9408e661c8f22cd8c4f486b8e5 (diff) | |
| download | lwn-7a36a752d006f6874049da510297eeb7f09d92a7.tar.gz lwn-7a36a752d006f6874049da510297eeb7f09d92a7.zip | |
get_user_pages(): fix possible page leak on oom
get_user_pages() must not return the error when i != 0. When pages !=
NULL we have i get_page()'ed pages.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/memory.c')
| -rw-r--r-- | mm/memory.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/memory.c b/mm/memory.c index 350e646032f5..2302d228fe04 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1151,7 +1151,7 @@ int get_user_pages(struct task_struct *tsk, struct mm_struct *mm, * be processed until returning to user space. */ if (unlikely(test_tsk_thread_flag(tsk, TIF_MEMDIE))) - return -ENOMEM; + return i ? i : -ENOMEM; if (write) foll_flags |= FOLL_WRITE; |