diff options
author | Krishnasamy, Somasundaram <Somasundaram.Krishnasamy@lsi.com> | 2011-02-28 18:13:22 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-14 16:53:20 -0700 |
commit | 40001773632081282f51a4cf582e0bb7fee7c225 (patch) | |
tree | 8aabf415b2a31451f2bdd8c294af907cd601378f /mm/failslab.c | |
parent | 56b7b7b97d500a63adb3bdb2a403d041b0f287be (diff) | |
download | lwn-40001773632081282f51a4cf582e0bb7fee7c225.tar.gz lwn-40001773632081282f51a4cf582e0bb7fee7c225.zip |
ses: Avoid kernel panic when lun 0 is not mapped
commit d1e12de804f9d8ad114786ca7c2ce593cba79891 upstream.
During device discovery, scsi mid layer sends INQUIRY command to LUN
0. If the LUN 0 is not mapped to host, it creates a temporary
scsi_device with LUN id 0 and sends REPORT_LUNS command to it. After
the REPORT_LUNS succeeds, it walks through the LUN table and adds each
LUN found to sysfs. At the end of REPORT_LUNS lun table scan, it will
delete the temporary scsi_device of LUN 0.
When scsi devices are added to sysfs, it calls add_dev function of all
the registered class interfaces. If ses driver has been registered,
ses_intf_add() of ses module will be called. This function calls
scsi_device_enclosure() to check the inquiry data for EncServ
bit. Since inquiry was not allocated for temporary LUN 0 scsi_device,
it will cause NULL pointer exception.
To fix the problem, sdev->inquiry is checked for NULL before reading it.
Signed-off-by: Somasundaram Krishnasamy <Somasundaram.Krishnasamy@lsi.com>
Signed-off-by: Babu Moger <babu.moger@lsi.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'mm/failslab.c')
0 files changed, 0 insertions, 0 deletions