diff options
| author | Jianglei Nie <niejianglei2021@163.com> | 2022-07-14 14:37:46 +0800 |
|---|---|---|
| committer | akpm <akpm@linux-foundation.org> | 2022-07-29 18:07:15 -0700 |
| commit | 188043c7f4f2bd662f2a55957d684fffa543e600 (patch) | |
| tree | cd27d171e03445fcd7271cacbf8a6f4c41e5da38 /mm/damon/reclaim.c | |
| parent | 73b73bac90d97400e29e585c678c4d0ebfd2680d (diff) | |
| download | lwn-188043c7f4f2bd662f2a55957d684fffa543e600.tar.gz lwn-188043c7f4f2bd662f2a55957d684fffa543e600.zip | |
mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()
damon_reclaim_init() allocates a memory chunk for ctx with
damon_new_ctx(). When damon_select_ops() fails, ctx is not released,
which will lead to a memory leak.
We should release the ctx with damon_destroy_ctx() when damon_select_ops()
fails to fix the memory leak.
Link: https://lkml.kernel.org/r/20220714063746.2343549-1-niejianglei2021@163.com
Fixes: 4d69c3457821 ("mm/damon/reclaim: use damon_select_ops() instead of damon_{v,p}a_set_operations()")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm/damon/reclaim.c')
| -rw-r--r-- | mm/damon/reclaim.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index e69b807fefe4..a7faf51b4bd4 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -435,8 +435,10 @@ static int __init damon_reclaim_init(void) if (!ctx) return -ENOMEM; - if (damon_select_ops(ctx, DAMON_OPS_PADDR)) + if (damon_select_ops(ctx, DAMON_OPS_PADDR)) { + damon_destroy_ctx(ctx); return -EINVAL; + } ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; ctx->callback.after_aggregation = damon_reclaim_after_aggregation; |