diff options
| author | Adam Borowski <kilobyte@angband.pl> | 2018-02-04 18:45:21 +0100 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2018-02-08 14:21:41 +0100 |
| commit | 3a129cc2151425e5aeb69aeb25fbc994ec738137 (patch) | |
| tree | db4b82232e26bfe2df75f7654e524ad321a657e1 /lib | |
| parent | ab486bc9a591689f3ac2b6ebc072309371f8f451 (diff) | |
| download | lwn-3a129cc2151425e5aeb69aeb25fbc994ec738137.tar.gz lwn-3a129cc2151425e5aeb69aeb25fbc994ec738137.zip | |
vsprintf: avoid misleading "(null)" for %px
Like %pK already does, print "00000000" instead.
This confused people -- the convention is that "(null)" means you tried to
dereference a null pointer as opposed to printing the address.
Link: http://lkml.kernel.org/r/20180204174521.21383-1-kilobyte@angband.pl
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: "Roberts, William C" <william.c.roberts@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Laight <David.Laight@ACULAB.COM>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/vsprintf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 77ee6ced11b1..d7a708f82559 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1849,7 +1849,7 @@ char *pointer(const char *fmt, char *buf, char *end, void *ptr, { const int default_width = 2 * sizeof(void *); - if (!ptr && *fmt != 'K') { + if (!ptr && *fmt != 'K' && *fmt != 'x') { /* * Print (null) with the same width as a pointer so it makes * tabular output look nice. |