diff options
author | Alexey Dobriyan <adobriyan@sw.ru> | 2008-04-18 15:43:32 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-04-18 15:43:32 -0700 |
commit | d1643d24c61b725bef399cc1cf2944b4c9c23177 (patch) | |
tree | ad629b19f6331058001ef46fe6a45dd53122b7d8 /lib | |
parent | 3c051235a7f115c34e675c9cf55820bd3435f860 (diff) | |
download | lwn-d1643d24c61b725bef399cc1cf2944b4c9c23177.tar.gz lwn-d1643d24c61b725bef399cc1cf2944b4c9c23177.zip |
[NET]: Fix and allocate less memory for ->priv'less netdevices
This patch effectively reverts commit d0498d9ae1a5cebac363e38907266d5cd2eedf89
aka "[NET]: Do not allocate unneeded memory for dev->priv alignment."
It was found to be buggy because of final unconditional += NETDEV_ALIGN_CONST
removal.
For example, for sizeof(struct net_device) being 2048 bytes, "alloc_size"
was also 2048 bytes, but allocator with debugging options turned on started
giving out !32-byte aligned memory resulting in redzones overwrites.
Patch does small optimization in ->priv'less case: bumping size to next
32-byte boundary was always done to ensure ->priv will also be aligned.
But, no ->priv, no need to do that.
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions