diff options
| author | Ilya Dryomov <idryomov@gmail.com> | 2019-01-08 19:47:38 +0100 |
|---|---|---|
| committer | Ilya Dryomov <idryomov@gmail.com> | 2019-01-10 09:45:09 +0100 |
| commit | 85f5a4d666fd9be73856ed16bb36c5af5b406b29 (patch) | |
| tree | 478748726b2075e0db2221d2553d46aa38f4edd5 /lib | |
| parent | c64a2b0516a02361d8deb1f038647c29020d0852 (diff) | |
| download | lwn-85f5a4d666fd9be73856ed16bb36c5af5b406b29.tar.gz lwn-85f5a4d666fd9be73856ed16bb36c5af5b406b29.zip | |
rbd: don't return 0 on unmap if RBD_DEV_FLAG_REMOVING is set
There is a window between when RBD_DEV_FLAG_REMOVING is set and when
the device is removed from rbd_dev_list. During this window, we set
"already" and return 0.
Returning 0 from write(2) can confuse userspace tools because
0 indicates that nothing was written. In particular, "rbd unmap"
will retry the write multiple times a second:
10:28:05.463299 write(4, "0", 1) = 0
10:28:05.463509 write(4, "0", 1) = 0
10:28:05.463720 write(4, "0", 1) = 0
10:28:05.463942 write(4, "0", 1) = 0
10:28:05.464155 write(4, "0", 1) = 0
Cc: stable@vger.kernel.org
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Tested-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions