diff options
| author | Philipp Stanner <pstanner@redhat.com> | 2024-06-13 13:50:19 +0200 |
|---|---|---|
| committer | Krzysztof Wilczyński <kwilczynski@kernel.org> | 2024-07-10 04:20:01 +0000 |
| commit | 81fcf28e74a3ffda67a6896cd38843d80bc9ec68 (patch) | |
| tree | ca35c8bd117969580ad614d67421148ee1114b37 /lib | |
| parent | d47bde708086c77b1ceeb7643e600089f63dd03b (diff) | |
| download | lwn-81fcf28e74a3ffda67a6896cd38843d80bc9ec68.tar.gz lwn-81fcf28e74a3ffda67a6896cd38843d80bc9ec68.zip | |
PCI: Document hybrid devres hazards
These functions:
pci_request_region()
pci_request_regions()
pci_request_regions_exclusive()
pci_request_selected_regions()
pci_request_selected_regions_exclusive()
pci_intx()
are "hybrid" functions that are managed if pcim_enable_device() has been
called, but unmanaged otherwise.
This is confusing and has already caused a bug (in 8558de401b5f
("drm/vboxvideo: use managed pci functions")) because users believe all PCI
functions, such as pci_iomap_range(), can become managed that way, which is
not the case.
Add comments to the relevant functions' docstrings that warn users about
this behavior.
Link: https://lore.kernel.org/r/20240613115032.29098-7-pstanner@redhat.com
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
[bhelgaas: commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions