diff options
| author | Luis Chamberlain <mcgrof@kernel.org> | 2018-11-30 14:09:21 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-11-30 14:56:14 -0800 |
| commit | 5618cf031fecda63847cafd1091e7b8bd626cdb1 (patch) | |
| tree | 1cfd09fef4a37093b0761f6d7492e5ca83a6703c /lib/test_kmod.c | |
| parent | c7d7d620dcbd2a1c595092280ca943f2fced7bbd (diff) | |
| download | lwn-5618cf031fecda63847cafd1091e7b8bd626cdb1.tar.gz lwn-5618cf031fecda63847cafd1091e7b8bd626cdb1.zip | |
lib/test_kmod.c: fix rmmod double free
We free the misc device string twice on rmmod; fix this. Without this
we cannot remove the module without crashing.
Link: http://lkml.kernel.org/r/20181124050500.5257-1-mcgrof@kernel.org
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: <stable@vger.kernel.org> [4.12+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/test_kmod.c')
| -rw-r--r-- | lib/test_kmod.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/test_kmod.c b/lib/test_kmod.c index e3ddd836491f..d82d022111e0 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -1214,7 +1214,6 @@ void unregister_test_dev_kmod(struct kmod_test_device *test_dev) dev_info(test_dev->dev, "removing interface\n"); misc_deregister(&test_dev->misc_dev); - kfree(&test_dev->misc_dev.name); mutex_unlock(&test_dev->config_mutex); mutex_unlock(&test_dev->trigger_mutex); |