diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2018-11-30 12:13:15 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-11-30 12:13:15 -0800 |
commit | b1286ed7158e9b62787508066283ab0b8850b518 (patch) | |
tree | efcf0ef8730690794bd1d87fcc4470603b59ef86 /lib/test_hexdump.c | |
parent | 1ec63573b2db363848abb313cc75eb29e9abc1b3 (diff) | |
download | lwn-b1286ed7158e9b62787508066283ab0b8850b518.tar.gz lwn-b1286ed7158e9b62787508066283ab0b8850b518.zip |
test_hexdump: use memcpy instead of strncpy
New versions of gcc reasonably warn about the odd pattern of
strncpy(p, q, strlen(q));
which really doesn't make sense: the strncpy() ends up being just a slow
and odd way to write memcpy() in this case.
Apparently there was a patch for this floating around earlier, but it
got lost.
Acked-again-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/test_hexdump.c')
-rw-r--r-- | lib/test_hexdump.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/test_hexdump.c b/lib/test_hexdump.c index 626f580b4ff7..5144899d3c6b 100644 --- a/lib/test_hexdump.c +++ b/lib/test_hexdump.c @@ -99,7 +99,7 @@ static void __init test_hexdump_prepare_test(size_t len, int rowsize, const char *q = *result++; size_t amount = strlen(q); - strncpy(p, q, amount); + memcpy(p, q, amount); p += amount; *p++ = ' '; |