summaryrefslogtreecommitdiff
path: root/lib/rhashtable.c
diff options
context:
space:
mode:
authorPaul Blakey <paulb@mellanox.com>2018-03-04 17:29:48 +0200
committerDavid S. Miller <davem@davemloft.net>2018-03-07 10:44:02 -0500
commitd3dcf8eb615537526bd42ff27a081d46d337816e (patch)
treeb9d783bcc753f9a78d238535a30a55050413eca8 /lib/rhashtable.c
parent25b5cdfcce1b57971840505dfc78556bd12dea6d (diff)
downloadlwn-d3dcf8eb615537526bd42ff27a081d46d337816e.tar.gz
lwn-d3dcf8eb615537526bd42ff27a081d46d337816e.zip
rhashtable: Fix rhlist duplicates insertion
When inserting duplicate objects (those with the same key), current rhlist implementation messes up the chain pointers by updating the bucket pointer instead of prev next pointer to the newly inserted node. This causes missing elements on removal and travesal. Fix that by properly updating pprev pointer to point to the correct rhash_head next pointer. Issue: 1241076 Change-Id: I86b2c140bcb4aeb10b70a72a267ff590bb2b17e7 Fixes: ca26893f05e8 ('rhashtable: Add rhlist interface') Signed-off-by: Paul Blakey <paulb@mellanox.com> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/rhashtable.c')
-rw-r--r--lib/rhashtable.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index 3825c30aaa36..47de025b6245 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -506,8 +506,10 @@ static void *rhashtable_lookup_one(struct rhashtable *ht,
if (!key ||
(ht->p.obj_cmpfn ?
ht->p.obj_cmpfn(&arg, rht_obj(ht, head)) :
- rhashtable_compare(&arg, rht_obj(ht, head))))
+ rhashtable_compare(&arg, rht_obj(ht, head)))) {
+ pprev = &head->next;
continue;
+ }
if (!ht->rhlist)
return rht_obj(ht, head);