diff options
| author | Tianjia Zhang <tianjia.zhang@linux.alibaba.com> | 2023-12-14 11:08:34 +0800 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2023-12-22 12:30:19 +0800 |
| commit | ba3c5574203034781ac4231acf117da917efcd2a (patch) | |
| tree | 2588f4eb98134fc5a03fe91458cd06815416a7c4 /lib/crypto | |
| parent | ae3bed72ac00e07637bd9e40fce84ff1a20fbf3d (diff) | |
| download | lwn-ba3c5574203034781ac4231acf117da917efcd2a.tar.gz lwn-ba3c5574203034781ac4231acf117da917efcd2a.zip | |
crypto: lib/mpi - Fix unexpected pointer access in mpi_ec_init
When the mpi_ec_ctx structure is initialized, some fields are not
cleared, causing a crash when referencing the field when the
structure was released. Initially, this issue was ignored because
memory for mpi_ec_ctx is allocated with the __GFP_ZERO flag.
For example, this error will be triggered when calculating the
Za value for SM2 separately.
Fixes: d58bb7e55a8a ("lib/mpi: Introduce ec implementation to MPI library")
Cc: stable@vger.kernel.org # v6.5
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'lib/crypto')
| -rw-r--r-- | lib/crypto/mpi/ec.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/crypto/mpi/ec.c b/lib/crypto/mpi/ec.c index 40f5908e57a4..e16dca1e23d5 100644 --- a/lib/crypto/mpi/ec.c +++ b/lib/crypto/mpi/ec.c @@ -584,6 +584,9 @@ void mpi_ec_init(struct mpi_ec_ctx *ctx, enum gcry_mpi_ec_models model, ctx->a = mpi_copy(a); ctx->b = mpi_copy(b); + ctx->d = NULL; + ctx->t.two_inv_p = NULL; + ctx->t.p_barrett = use_barrett > 0 ? mpi_barrett_init(ctx->p, 0) : NULL; mpi_ec_get_reset(ctx); |