diff options
author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-04-10 21:17:29 +0800 |
---|---|---|
committer | Jon Mason <jdmason@kudzu.us> | 2018-06-11 15:20:59 -0400 |
commit | 82edcc758f273ed3afd308746dd69376d5b1024d (patch) | |
tree | 3aa9dfecafb053dfc07a1f2f8673c00fdd30c941 /lib/crc32defs.h | |
parent | 081a698639d793d92c28e785d9b5b085698f8008 (diff) | |
download | lwn-82edcc758f273ed3afd308746dd69376d5b1024d.tar.gz lwn-82edcc758f273ed3afd308746dd69376d5b1024d.zip |
ntb: ntb_transport: Replace GFP_ATOMIC with GFP_KERNEL in ntb_transport_setup_qp_mw
ntb_transport_setup_qp_mw() is never called in atomic context.
ntb_transport_setup_qp_mw() is only called by ntb_transport_link_work(),
which is set as a parameter of INIT_DELAYED_WORK()
in ntb_transport_probe().
Despite never getting called from atomic context,
ntb_transport_setup_qp_mw() calls kzalloc_node() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'lib/crc32defs.h')
0 files changed, 0 insertions, 0 deletions