diff options
author | Justin Stitt <justinstitt@google.com> | 2023-10-05 00:05:35 +0000 |
---|---|---|
committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2023-10-05 09:51:18 +0200 |
commit | 3b9333493b5fa69f2dce8eb96bbef32df1b65c4a (patch) | |
tree | 7053dc3a08abce843a8b954746e695702eb358ea /kernel | |
parent | dd8bb80308c474ea0e7ddb244962cb2d7001bae2 (diff) | |
download | lwn-3b9333493b5fa69f2dce8eb96bbef32df1b65c4a.tar.gz lwn-3b9333493b5fa69f2dce8eb96bbef32df1b65c4a.zip |
can: peak_pci: replace deprecated strncpy with strscpy
`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
NUL-padding is not required since card is already zero-initialized:
| card = kzalloc(sizeof(*card), GFP_KERNEL);
A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on the destination buffer without
unnecessarily NUL-padding.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/all/20231005-strncpy-drivers-net-can-sja1000-peak_pci-c-v1-1-c36e1702cd56@google.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions