diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2012-04-10 10:50:55 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2012-04-10 11:00:30 +0200 |
| commit | 9886f444129171569461d8c39983e16f4871e3b4 (patch) | |
| tree | 2ceefb3988e602a58f8055b4ec82b00eb306abf9 /kernel | |
| parent | 6f103929f8979d2638e58d7f7fda0beefcb8ee7e (diff) | |
| download | lwn-9886f444129171569461d8c39983e16f4871e3b4.tar.gz lwn-9886f444129171569461d8c39983e16f4871e3b4.zip | |
itimer: Use printk_once instead of WARN_ONCE
David pointed out, that WARN_ONCE() to report usage of an deprecated
misfeature make folks unhappy. Use printk_once() instead.
Andrew told me to stop grumbling and to remove the silly typecast
while touching the file.
Reported-by: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/itimer.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/itimer.c b/kernel/itimer.c index c70369a74b5a..8d262b467573 100644 --- a/kernel/itimer.c +++ b/kernel/itimer.c @@ -285,9 +285,10 @@ SYSCALL_DEFINE3(setitimer, int, which, struct itimerval __user *, value, if(copy_from_user(&set_buffer, value, sizeof(set_buffer))) return -EFAULT; } else { - memset((char *) &set_buffer, 0, sizeof(set_buffer)); - WARN_ONCE(1, "setitimer: new_value pointer is NULL." - " Misfeature support will be removed\n"); + memset(&set_buffer, 0, sizeof(set_buffer)); + printk_once(KERN_WARNING "%s calls setitimer() with new_value NULL pointer." + " Misfeature support will be removed\n", + current->comm); } error = do_setitimer(which, &set_buffer, ovalue ? &get_buffer : NULL); |