diff options
author | Steven Rostedt <rostedt@goodmis.org> | 2015-05-09 03:06:23 +0930 |
---|---|---|
committer | Jiri Slaby <jslaby@suse.cz> | 2016-01-05 16:51:53 +0100 |
commit | ff69744b4eee3af797f92d9756902078e4249b19 (patch) | |
tree | 9973f4ab9b25425f3b8230cc67ee42d794c5d51e /kernel | |
parent | c746b3ce1c9ef2026dda724bc84560649ffe374c (diff) | |
download | lwn-ff69744b4eee3af797f92d9756902078e4249b19.tar.gz lwn-ff69744b4eee3af797f92d9756902078e4249b19.zip |
module: Call module notifier on failure after complete_formation()
commit 37815bf866ab6722a47550f8d25ad3f1a16a680c upstream.
The module notifier call chain for MODULE_STATE_COMING was moved up before
the parsing of args, into the complete_formation() call. But if the module failed
to load after that, the notifier call chain for MODULE_STATE_GOING was
never called and that prevented the users of those call chains from
cleaning up anything that was allocated.
Link: http://lkml.kernel.org/r/554C52B9.9060700@gmail.com
Reported-by: Pontus Fuchs <pontus.fuchs@gmail.com>
Fixes: 4982223e51e8 "module: set nx before marking module MODULE_STATE_COMING"
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/module.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/module.c b/kernel/module.c index 3e3f90d82ecc..7d1c2ea27898 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3337,6 +3337,9 @@ static int load_module(struct load_info *info, const char __user *uargs, module_bug_cleanup(mod); mutex_unlock(&module_mutex); + blocking_notifier_call_chain(&module_notify_list, + MODULE_STATE_GOING, mod); + /* we can't deallocate the module until we clear memory protection */ unset_module_init_ro_nx(mod); unset_module_core_ro_nx(mod); |