summaryrefslogtreecommitdiff
path: root/kernel
diff options
context:
space:
mode:
authorMathias Krause <minipli@googlemail.com>2013-09-30 22:04:24 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-12-04 10:57:02 -0800
commit3dc7095c8e78dfeb20dce066fe8bfdfd8497212e (patch)
tree14f98c32e75f8a7e1568159e643e97067c7a375f /kernel
parentd6770065f950cf0f7a2d89b4b419af6c0499ccfe (diff)
downloadlwn-3dc7095c8e78dfeb20dce066fe8bfdfd8497212e.tar.gz
lwn-3dc7095c8e78dfeb20dce066fe8bfdfd8497212e.zip
audit: fix info leak in AUDIT_GET requests
commit 64fbff9ae0a0a843365d922e0057fc785f23f0e3 upstream. We leak 4 bytes of kernel stack in response to an AUDIT_GET request as we miss to initialize the mask member of status_set. Fix that. Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Eric Paris <eparis@redhat.com> Signed-off-by: Mathias Krause <minipli@googlemail.com> Signed-off-by: Richard Guy Briggs <rgb@redhat.com> Signed-off-by: Eric Paris <eparis@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/audit.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/audit.c b/kernel/audit.c
index 5ce53337a9e4..34eeb48f9c34 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -659,6 +659,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
switch (msg_type) {
case AUDIT_GET:
+ status_set.mask = 0;
status_set.enabled = audit_enabled;
status_set.failure = audit_failure;
status_set.pid = audit_pid;