diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2007-09-16 15:36:43 +0200 |
|---|---|---|
| committer | Thomas Gleixner <tglx@chaos.(none)> | 2007-09-16 15:36:43 +0200 |
| commit | 07eec6af448d13a6a520d9c6f06f2e87f61b567a (patch) | |
| tree | eabd8fdf97ab76ff3abfa2c2804bb449f393ca01 /kernel | |
| parent | 729c6ba334771f28a54efd7e3b8f5ab9414ce7bc (diff) | |
| download | lwn-07eec6af448d13a6a520d9c6f06f2e87f61b567a.tar.gz lwn-07eec6af448d13a6a520d9c6f06f2e87f61b567a.zip | |
clockevents: Enforce oneshot broadcast when broadcast mask is set on resume
The jinxed VAIO refuses to resume without hitting keys on the keyboard
when this is not enforced. It is unclear why the cpu ends up in a lower
C State without notifying the clock events layer, but enforcing the
oneshot broadcast here is safe.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/time/tick-broadcast.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index db8e0f3d409b..947959fb2bb5 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -382,12 +382,23 @@ static int tick_broadcast_set_event(ktime_t expires, int force) int tick_resume_broadcast_oneshot(struct clock_event_device *bc) { + int cpu = smp_processor_id(); + + /* + * If the CPU is marked for broadcast, enforce oneshot + * broadcast mode. The jinxed VAIO does not resume otherwise. + * No idea why it ends up in a lower C State during resume + * without notifying the clock events layer. + */ + if (cpu_isset(cpu, tick_broadcast_mask)) + cpu_set(cpu, tick_broadcast_oneshot_mask); + clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT); if(!cpus_empty(tick_broadcast_oneshot_mask)) tick_broadcast_set_event(ktime_get(), 1); - return cpu_isset(smp_processor_id(), tick_broadcast_oneshot_mask); + return cpu_isset(cpu, tick_broadcast_oneshot_mask); } /* |