summaryrefslogtreecommitdiff
path: root/kernel/workqueue.c
diff options
context:
space:
mode:
authorMathieu Malaterre <malat@debian.org>2018-05-22 21:47:32 +0200
committerTejun Heo <tj@kernel.org>2018-05-23 11:16:58 -0700
commit66448bc274cadedb71fda7d914e7c29d8dead217 (patch)
treea995effcf0fa2a7a5b08381cca9e6a337ab86b6b /kernel/workqueue.c
parent197f6accacdaf9a0cf4da3c4ac8dd788633c0e38 (diff)
downloadlwn-66448bc274cadedb71fda7d914e7c29d8dead217.tar.gz
lwn-66448bc274cadedb71fda7d914e7c29d8dead217.zip
workqueue: move function definitions within CONFIG_SMP block
In commit 7ee681b25284 ("workqueue: Convert to state machine callbacks"), three new function definitions were added: ‘workqueue_prepare_cpu’, ‘workqueue_online_cpu’ and ‘workqueue_offline_cpu’. Move these function definitions within a CONFIG_SMP block since they are not used outside of it. This will match function declarations in header <include/linux/workqueue.h>, and silence the following gcc warning (W=1): kernel/workqueue.c:4743:5: warning: no previous prototype for ‘workqueue_prepare_cpu’ [-Wmissing-prototypes] kernel/workqueue.c:4756:5: warning: no previous prototype for ‘workqueue_online_cpu’ [-Wmissing-prototypes] kernel/workqueue.c:4783:5: warning: no previous prototype for ‘workqueue_offline_cpu’ [-Wmissing-prototypes] Signed-off-by: Mathieu Malaterre <malat@debian.org> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
-rw-r--r--kernel/workqueue.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 60d6fd2636f3..7ea75529eabb 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4626,6 +4626,8 @@ void wq_worker_comm(char *buf, size_t size, struct task_struct *task)
mutex_unlock(&wq_pool_attach_mutex);
}
+#ifdef CONFIG_SMP
+
/*
* CPU hotplug.
*
@@ -4846,8 +4848,6 @@ int workqueue_offline_cpu(unsigned int cpu)
return 0;
}
-#ifdef CONFIG_SMP
-
struct work_for_cpu {
struct work_struct work;
long (*fn)(void *);