diff options
| author | Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> | 2023-06-30 21:28:53 +0900 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2023-07-10 10:39:17 -1000 |
| commit | 20bdedafd2f63e0ba70991127f9b5c0826ebdb32 (patch) | |
| tree | fc7307d993e44f29546fb693a43721c5664371ec /kernel/workqueue.c | |
| parent | 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c (diff) | |
| download | lwn-20bdedafd2f63e0ba70991127f9b5c0826ebdb32.tar.gz lwn-20bdedafd2f63e0ba70991127f9b5c0826ebdb32.zip | |
workqueue: Warn attempt to flush system-wide workqueues.
Based on commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using
a macro"), all in-tree users stopped flushing system-wide workqueues.
Therefore, start emitting runtime message so that all out-of-tree users
will understand that they need to update their code.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 02a8f402eeb5..f8891552fdd6 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -6571,10 +6571,9 @@ void __init workqueue_init(void) wq_watchdog_init(); } -/* - * Despite the naming, this is a no-op function which is here only for avoiding - * link error. Since compile-time warning may fail to catch, we will need to - * emit run-time warning from __flush_workqueue(). - */ -void __warn_flushing_systemwide_wq(void) { } +void __warn_flushing_systemwide_wq(void) +{ + pr_warn("WARNING: Flushing system-wide workqueues will be prohibited in near future.\n"); + dump_stack(); +} EXPORT_SYMBOL(__warn_flushing_systemwide_wq); |