diff options
| author | Paul E. McKenney <paulmck@kernel.org> | 2021-11-30 17:00:30 -0800 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2021-12-01 06:47:45 -1000 |
| commit | 443378f0664a78756c3e3aeaab92750fe1e05735 (patch) | |
| tree | fa6d62e9f53ecaa1cba1b3be3405307fe518d7b3 /kernel/workqueue.c | |
| parent | 58e1100fdc5990b0cc0d4beaf2562a92e621ac7d (diff) | |
| download | lwn-443378f0664a78756c3e3aeaab92750fe1e05735.tar.gz lwn-443378f0664a78756c3e3aeaab92750fe1e05735.zip | |
workqueue: Upgrade queue_work_on() comment
The current queue_work_on() docbook comment says that the caller must
ensure that the specified CPU can't go away, but does not spell out the
consequences, which turn out to be quite mild. Therefore expand this
comment to explicitly say that the penalty for failing to nail down the
specified CPU is that the workqueue handler might find itself executing
on some other CPU.
Cc: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 613917bbc4e7..332361cf215f 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1531,7 +1531,8 @@ out: * @work: work to queue * * We queue the work to a specific CPU, the caller must ensure it - * can't go away. + * can't go away. Callers that fail to ensure that the specified + * CPU cannot go away will execute on a randomly chosen CPU. * * Return: %false if @work was already on a queue, %true otherwise. */ |