diff options
| author | Ingo Molnar <mingo@elte.hu> | 2006-12-18 20:05:09 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-21 00:20:01 -0800 |
| commit | 9bfb18392ef586467277fa25d8f3a7a93611f6df (patch) | |
| tree | e0bb6aab4983a50f54b247ac3db323dbb8d025a2 /kernel/workqueue.c | |
| parent | 5ccac88eeb5659c716af8e695e2943509c80d172 (diff) | |
| download | lwn-9bfb18392ef586467277fa25d8f3a7a93611f6df.tar.gz lwn-9bfb18392ef586467277fa25d8f3a7a93611f6df.zip | |
[PATCH] workqueue: fix schedule_on_each_cpu()
fix the schedule_on_each_cpu() implementation: __queue_work() is now
stricter, hence set the work-pending bit before passing in the new work.
(found in the -rt tree, using Peter Zijlstra's files-lock scalability
patchset)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 742cbbe49bdc..180a8ce11535 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -637,9 +637,11 @@ int schedule_on_each_cpu(work_func_t func) mutex_lock(&workqueue_mutex); for_each_online_cpu(cpu) { - INIT_WORK(per_cpu_ptr(works, cpu), func); - __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), - per_cpu_ptr(works, cpu)); + struct work_struct *work = per_cpu_ptr(works, cpu); + + INIT_WORK(work, func); + set_bit(WORK_STRUCT_PENDING, work_data_bits(work)); + __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), work); } mutex_unlock(&workqueue_mutex); flush_workqueue(keventd_wq); |