diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2009-03-16 19:20:15 -0400 |
|---|---|---|
| committer | Steven Rostedt <srostedt@redhat.com> | 2009-03-16 23:27:06 -0400 |
| commit | 4ca530852346be239b7c19e7bec5d2b78855bebe (patch) | |
| tree | 96e5252faaf362115a96ed6df7c4e4f698a027dc /kernel/trace/trace.h | |
| parent | 03303549b1695dc024d4a653cc16bd79f78f9750 (diff) | |
| download | lwn-4ca530852346be239b7c19e7bec5d2b78855bebe.tar.gz lwn-4ca530852346be239b7c19e7bec5d2b78855bebe.zip | |
tracing: protect reader of cmdline output
Impact: fix to one cause of incorrect comm outputs in trace
The spinlock only protected the creation of a comm <=> pid pair.
But it was possible that a reader could look up a pid, and get the
wrong comm because it had no locking.
This also required changing trace_find_cmdline to copy the comm cache
and not just send back a pointer to it.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Diffstat (limited to 'kernel/trace/trace.h')
| -rw-r--r-- | kernel/trace/trace.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 56ce34d90b03..b0ecad8ecc34 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -547,7 +547,7 @@ struct tracer_switch_ops { }; #endif /* CONFIG_CONTEXT_SWITCH_TRACER */ -extern char *trace_find_cmdline(int pid); +extern void trace_find_cmdline(int pid, char comm[]); #ifdef CONFIG_DYNAMIC_FTRACE extern unsigned long ftrace_update_tot_cnt; |