diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2009-07-22 23:29:30 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2009-07-23 10:07:18 -0400 |
| commit | 8650ae32ef7045e763825dee6256dde7f331bb85 (patch) | |
| tree | 546a07e4c5b6fc731b48604769392a671c1fb18e /kernel/trace/trace.c | |
| parent | 4c739ff043e5787d97c9691d62cabf7a29e75a9d (diff) | |
| download | lwn-8650ae32ef7045e763825dee6256dde7f331bb85.tar.gz lwn-8650ae32ef7045e763825dee6256dde7f331bb85.zip | |
tracing: only truncate ftrace files when O_TRUNC is set
The current code will truncate the ftrace files contents if O_APPEND
is not set and the file is opened in write mode. This is incorrect.
It should only truncate the file if O_TRUNC is set. Otherwise
if one of these files is opened by a C program with fopen "r+",
it will incorrectly truncate the file.
Reported-by: Jiri Olsa <jolsa@redhat.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace.c')
| -rw-r--r-- | kernel/trace/trace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 8bc8d8afea6a..d8ef28574aa1 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -2031,7 +2031,7 @@ static int tracing_open(struct inode *inode, struct file *file) /* If this file was open for write, then erase contents */ if ((file->f_mode & FMODE_WRITE) && - !(file->f_flags & O_APPEND)) { + (file->f_flags & O_TRUNC)) { long cpu = (long) inode->i_private; if (cpu == TRACE_PIPE_ALL_CPU) |