diff options
| author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2016-11-23 15:52:45 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2016-11-23 15:52:45 -0500 |
| commit | 4239174570da080f3623724d97062bf55de7e36b (patch) | |
| tree | 8a2907e9feda1675a82c03414b62b1be36151cb3 /kernel/sysctl.c | |
| parent | 929ddbf3ef4e07fef67e93e998020d49d2533724 (diff) | |
| download | lwn-4239174570da080f3623724d97062bf55de7e36b.tar.gz lwn-4239174570da080f3623724d97062bf55de7e36b.zip | |
tracing: Make tracepoint_printk a static_key
Currently, when tracepoint_printk is set (enabled by the "tp_printk" kernel
command line), it causes trace events to print via printk(). This is a very
dangerous operation, but is useful for debugging.
The issue is, it's seldom used, but it is always checked even if it's not
enabled by the kernel command line. Instead of having this feature called by
a branch against a variable, turn that variable into a static key, and this
will remove the test and jump.
To simplify things, the functions output_printk() and
trace_event_buffer_commit() were moved from trace_events.c to trace.c.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/sysctl.c')
| -rw-r--r-- | kernel/sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 706309f9ed84..6ccc60dfbc7a 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -634,7 +634,7 @@ static struct ctl_table kern_table[] = { .data = &tracepoint_printk, .maxlen = sizeof(tracepoint_printk), .mode = 0644, - .proc_handler = proc_dointvec, + .proc_handler = tracepoint_printk_sysctl, }, #endif #ifdef CONFIG_KEXEC_CORE |