diff options
author | Jiri Slaby <jslaby@suse.cz> | 2014-04-14 09:46:50 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-04-26 17:13:19 -0700 |
commit | eea7ead860ea8622d2d4b1cfbd63649beed91a9b (patch) | |
tree | ddaf413fc4f011d4535e1583d3588b48d817230e /kernel/stacktrace.c | |
parent | 036132b3be6073ecdeec7f1f3ad3606269ebf9c9 (diff) | |
download | lwn-eea7ead860ea8622d2d4b1cfbd63649beed91a9b.tar.gz lwn-eea7ead860ea8622d2d4b1cfbd63649beed91a9b.zip |
Char: ipmi_bt_sm, fix infinite loop
commit a94cdd1f4d30f12904ab528152731fb13a812a16 upstream.
In read_all_bytes, we do
unsigned char i;
...
bt->read_data[0] = BMC2HOST;
bt->read_count = bt->read_data[0];
...
for (i = 1; i <= bt->read_count; i++)
bt->read_data[i] = BMC2HOST;
If bt->read_data[0] == bt->read_count == 255, we loop infinitely in the
'for' loop. Make 'i' an 'int' instead of 'char' to get rid of the
overflow and finish the loop after 255 iterations every time.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-and-debugged-by: Rui Hui Dian <rhdian@novell.com>
Cc: Tomas Cech <tcech@suse.cz>
Cc: Corey Minyard <minyard@acm.org>
Cc: <openipmi-developer@lists.sourceforge.net>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/stacktrace.c')
0 files changed, 0 insertions, 0 deletions