diff options
| author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2010-03-10 17:07:24 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2010-03-11 15:21:50 +0100 |
| commit | 3d07467b7aa91623b31d7b5888a123a2c8c8e9cc (patch) | |
| tree | f7acd28870838db783146b3c87f1d56bd1c42ef2 /kernel/sched_rt.c | |
| parent | ab3b3aa5dd01b3aaa6b15caee113b21b1b6520c4 (diff) | |
| download | lwn-3d07467b7aa91623b31d7b5888a123a2c8c8e9cc.tar.gz lwn-3d07467b7aa91623b31d7b5888a123a2c8c8e9cc.zip | |
sched: Fix pick_next_highest_task_rt() for cgroups
Since pick_next_highest_task_rt() already iterates all the cgroups and
is really only interested in tasks, skip over the !task entries.
Reported-by: Dhaval Giani <dhaval.giani@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Tested-by: Dhaval Giani <dhaval.giani@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched_rt.c')
| -rw-r--r-- | kernel/sched_rt.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c index bf3e38fdbe6d..c4fb42a66cab 100644 --- a/kernel/sched_rt.c +++ b/kernel/sched_rt.c @@ -1146,7 +1146,12 @@ static struct task_struct *pick_next_highest_task_rt(struct rq *rq, int cpu) if (next && next->prio < idx) continue; list_for_each_entry(rt_se, array->queue + idx, run_list) { - struct task_struct *p = rt_task_of(rt_se); + struct task_struct *p; + + if (!rt_entity_is_task(rt_se)) + continue; + + p = rt_task_of(rt_se); if (pick_rt_task(rq, p, cpu)) { next = p; break; |