diff options
| author | Yang Yang <yang.yang29@zte.com.cn> | 2023-10-10 16:41:07 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2023-10-11 23:07:50 +0200 |
| commit | 80cc1d1d5ee35701daf11725ce06d8a240588973 (patch) | |
| tree | 893cc949948549acdac85f1f202567d600ffd1a0 /kernel/sched | |
| parent | b19fdb16fb2167c6bc9ee8fbc0c1d2d4fd3e2eb8 (diff) | |
| download | lwn-80cc1d1d5ee35701daf11725ce06d8a240588973.tar.gz lwn-80cc1d1d5ee35701daf11725ce06d8a240588973.zip | |
sched/psi: Avoid updating PSI triggers and ->rtpoll_total when there are no state changes
When psimon wakes up and there are no state changes for ->rtpoll_states,
it's unnecessary to update triggers and ->rtpoll_total because the pressures
being monitored by the user have not changed.
This will help to slightly reduce unnecessary computations of PSI.
[ mingo: Changelog updates ]
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Peter Ziljstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/202310101641075436843@zte.com.cn
Diffstat (limited to 'kernel/sched')
| -rw-r--r-- | kernel/sched/psi.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index be853f227e40..79f8db0c6150 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -704,11 +704,12 @@ static void psi_rtpoll_work(struct psi_group *group) } if (now >= group->rtpoll_next_update) { - update_triggers(group, now, &update_total, PSI_POLL); - group->rtpoll_next_update = now + group->rtpoll_min_period; - if (update_total) + if (changed_states & group->rtpoll_states) { + update_triggers(group, now, &update_total, PSI_POLL); memcpy(group->rtpoll_total, group->total[PSI_POLL], sizeof(group->rtpoll_total)); + } + group->rtpoll_next_update = now + group->rtpoll_min_period; } psi_schedule_rtpoll_work(group, |