diff options
author | Valentin Schneider <valentin.schneider@arm.com> | 2019-02-11 17:59:45 +0000 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2019-03-19 12:06:15 +0100 |
commit | a0fe2cf086aef213d1b4bca1b1291a3dee8357c9 (patch) | |
tree | 0b8bb7a403e6f4f06626faed6888a389dde6fca8 /kernel/sched/cpufreq_schedutil.c | |
parent | e25a7a944f1936b5134b7ee06bc432fc701e4aa3 (diff) | |
download | lwn-a0fe2cf086aef213d1b4bca1b1291a3dee8357c9.tar.gz lwn-a0fe2cf086aef213d1b4bca1b1291a3dee8357c9.zip |
sched/fair: Tune down misfit NOHZ kicks
In this commit:
3b1baa6496e6 ("sched/fair: Add 'group_misfit_task' load-balance type")
we set rq->misfit_task_load whenever the current running task has a
utilization greater than 80% of rq->cpu_capacity. A non-zero value in
this field enables misfit load balancing.
However, if the task being looked at is already running on a CPU of
highest capacity, there's nothing more we can do for it. We can
currently spot this in update_sd_pick_busiest(), which prevents us
from selecting a sched_group of group_type == group_misfit_task as the
busiest group, but we don't do any of that in nohz_balancer_kick().
This means that we could repeatedly kick NOHZ CPUs when there's no
improvements in terms of load balance to be done.
Introduce a check_misfit_status() helper that returns true iff there
is a CPU in the system that could give more CPU capacity to a rq's
misfit task - IOW, there exists a CPU of higher capacity_orig or the
rq's CPU is severely pressured by rt/IRQ.
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dietmar.Eggemann@arm.com
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: morten.rasmussen@arm.com
Cc: vincent.guittot@linaro.org
Link: https://lkml.kernel.org/r/20190211175946.4961-3-valentin.schneider@arm.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched/cpufreq_schedutil.c')
0 files changed, 0 insertions, 0 deletions