summaryrefslogtreecommitdiff
path: root/kernel/sched/Makefile
diff options
context:
space:
mode:
authorSteven Rostedt <rostedt@goodmis.org>2014-05-27 17:02:04 -0400
committerIngo Molnar <mingo@kernel.org>2014-06-05 11:07:41 +0200
commite9dd685ce81815811fb4da72e6ab10a694ac8468 (patch)
treec429c73cf5883cf54aef8b07c71b212c1c708071 /kernel/sched/Makefile
parent6acbfb96976fc3350e30d964acb1dbbdf876d55e (diff)
downloadlwn-e9dd685ce81815811fb4da72e6ab10a694ac8468.tar.gz
lwn-e9dd685ce81815811fb4da72e6ab10a694ac8468.zip
sched/numa: Fix use of spin_{un}lock_irq() when interrupts are disabled
As Peter Zijlstra told me, we have the following path: do_exit() exit_itimers() itimer_delete() spin_lock_irqsave(&timer->it_lock, &flags); timer_delete_hook(timer); kc->timer_del(timer) := posix_cpu_timer_del() put_task_struct() __put_task_struct() task_numa_free() spin_lock(&grp->lock); Which means that task_numa_free() can be called with interrupts disabled, which means that we should not be using spin_lock_irq() but spin_lock_irqsave() instead. Otherwise we are enabling interrupts while holding an interrupt unsafe lock! Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner<tglx@linutronix.de> Cc: Mike Galbraith <umgwanakikbuti@gmail.com> Cc: Eric Dumazet <eric.dumazet@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Link: http://lkml.kernel.org/r/20140527182541.GH11096@twins.programming.kicks-ass.net Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched/Makefile')
0 files changed, 0 insertions, 0 deletions