diff options
| author | Ingo Molnar <mingo@elte.hu> | 2007-10-15 17:00:13 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2007-10-15 17:00:13 +0200 |
| commit | a65914b3658043da27c159b8a28c5811bb0a88c9 (patch) | |
| tree | 2fc518e91c9a16f7596e1da861bd6c17abf09c07 /kernel/sched.c | |
| parent | 8927f49479756c1aff76e8202ad32733c965864f (diff) | |
| download | lwn-a65914b3658043da27c159b8a28c5811bb0a88c9.tar.gz lwn-a65914b3658043da27c159b8a28c5811bb0a88c9.zip | |
sched: kfree(NULL) is valid
kfree(NULL) is valid.
pointed out by checkpatch.pl.
the fix shrinks the code a bit:
text data bss dec hex filename
40024 3842 100 43966 abbe sched.o.before
40002 3842 100 43944 aba8 sched.o.after
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
| -rw-r--r-- | kernel/sched.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/kernel/sched.c b/kernel/sched.c index 10b7bedfa35a..23da93360b22 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -6784,17 +6784,14 @@ struct task_grp *sched_create_group(void) err: for_each_possible_cpu(i) { - if (tg->cfs_rq && tg->cfs_rq[i]) + if (tg->cfs_rq) kfree(tg->cfs_rq[i]); - if (tg->se && tg->se[i]) + if (tg->se) kfree(tg->se[i]); } - if (tg->cfs_rq) - kfree(tg->cfs_rq); - if (tg->se) - kfree(tg->se); - if (tg) - kfree(tg); + kfree(tg->cfs_rq); + kfree(tg->se); + kfree(tg); return ERR_PTR(-ENOMEM); } |