diff options
| author | Jiri Slaby <jirislaby@gmail.com> | 2009-01-17 12:04:36 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-01-18 20:29:35 +0100 |
| commit | b786c6a98ef6fa81114ba7b9fbfc0d67060775e3 (patch) | |
| tree | bff900158067adba76c14a61499e4d9520463e86 /kernel/relay.c | |
| parent | fdb6a8f4db813b4e50f4e975efe6be12ba5bf460 (diff) | |
| download | lwn-b786c6a98ef6fa81114ba7b9fbfc0d67060775e3.tar.gz lwn-b786c6a98ef6fa81114ba7b9fbfc0d67060775e3.zip | |
relay: fix lock imbalance in relay_late_setup_files
One fail path in relay_late_setup_files() omits
mutex_unlock(&relay_channels_mutex);
Add it.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/relay.c')
| -rw-r--r-- | kernel/relay.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/relay.c b/kernel/relay.c index 09ac2008f77b..9d79b7854fa6 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -663,8 +663,10 @@ int relay_late_setup_files(struct rchan *chan, mutex_lock(&relay_channels_mutex); /* Is chan already set up? */ - if (unlikely(chan->has_base_filename)) + if (unlikely(chan->has_base_filename)) { + mutex_unlock(&relay_channels_mutex); return -EEXIST; + } chan->has_base_filename = 1; chan->parent = parent; curr_cpu = get_cpu(); |