diff options
| author | Zhouyi Zhou <zhouzhouyi@gmail.com> | 2021-01-11 09:08:59 +0800 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@kernel.org> | 2021-03-08 14:17:35 -0800 |
| commit | 6494ccb93271bee596a12db32ff44867d5be2321 (patch) | |
| tree | 28b8ddd7d65f49e1ed3651da783a804bef3651f2 /kernel/rcu/tree.c | |
| parent | 47fcbc8dd62f15dc75916225ebacdc3bca9c12b2 (diff) | |
| download | lwn-6494ccb93271bee596a12db32ff44867d5be2321.tar.gz lwn-6494ccb93271bee596a12db32ff44867d5be2321.zip | |
rcu: Remove spurious instrumentation_end() in rcu_nmi_enter()
In rcu_nmi_enter(), there is an erroneous instrumentation_end() in the
second branch of the "if" statement. Oddly enough, "objtool check -f
vmlinux.o" fails to complain because it is unable to correctly cover
all cases. Instead, objtool visits the third branch first, which marks
following trace_rcu_dyntick() as visited. This commit therefore removes
the spurious instrumentation_end().
Fixes: 04b25a495bd6 ("rcu: Mark rcu_nmi_enter() call to rcu_cleanup_after_idle() noinstr")
Reported-by Neeraj Upadhyay <neeraju@codeaurora.org>
Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Diffstat (limited to 'kernel/rcu/tree.c')
| -rw-r--r-- | kernel/rcu/tree.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index e62c2defae98..4d90f202ef4a 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1076,7 +1076,6 @@ noinstr void rcu_nmi_enter(void) } else if (!in_nmi()) { instrumentation_begin(); rcu_irq_enter_check_tick(); - instrumentation_end(); } else { instrumentation_begin(); } |