diff options
| author | Stanislaw Gruszka <sgruszka@redhat.com> | 2009-11-17 14:14:13 -0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2009-11-18 12:36:05 +0100 |
| commit | ba5ea951d0b5e5896180e21fe07f228d2b3b0e63 (patch) | |
| tree | f636c31ec68aed0d1e758c8aa36c06e320945ad8 /kernel/posix-cpu-timers.c | |
| parent | 8e1a928a2ed7e8d5cad97c8e985294b4caedd168 (diff) | |
| download | lwn-ba5ea951d0b5e5896180e21fe07f228d2b3b0e63.tar.gz lwn-ba5ea951d0b5e5896180e21fe07f228d2b3b0e63.zip | |
posix-cpu-timers: optimize and document timer_create callback
We have already new_timer initialized to all-zeros hence in function
initializations are not needed. Document function expectation about
new_timer argument as well.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: johnstul@us.ibm.com
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/posix-cpu-timers.c')
| -rw-r--r-- | kernel/posix-cpu-timers.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c index 5c9dc228747b..438ff4523513 100644 --- a/kernel/posix-cpu-timers.c +++ b/kernel/posix-cpu-timers.c @@ -384,7 +384,8 @@ int posix_cpu_clock_get(const clockid_t which_clock, struct timespec *tp) /* * Validate the clockid_t for a new CPU-clock timer, and initialize the timer. - * This is called from sys_timer_create with the new timer already locked. + * This is called from sys_timer_create() and do_cpu_nanosleep() with the + * new timer already all-zeros initialized. */ int posix_cpu_timer_create(struct k_itimer *new_timer) { @@ -396,8 +397,6 @@ int posix_cpu_timer_create(struct k_itimer *new_timer) return -EINVAL; INIT_LIST_HEAD(&new_timer->it.cpu.entry); - new_timer->it.cpu.incr.sched = 0; - new_timer->it.cpu.expires.sched = 0; read_lock(&tasklist_lock); if (CPUCLOCK_PERTHREAD(new_timer->it_clock)) { |