diff options
| author | Li Zefan <lizf@cn.fujitsu.com> | 2009-08-17 13:39:49 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-08-17 09:54:40 +0200 |
| commit | e9d65725bdf5954283625ca4d770bfc34f2ae56a (patch) | |
| tree | 422219331fb039396ff24d9df6e1d5293cde1bd4 /kernel/lockdep_proc.c | |
| parent | 212274347fc4d2a7c56bf6c953b02c809e7e0be1 (diff) | |
| download | lwn-e9d65725bdf5954283625ca4d770bfc34f2ae56a.tar.gz lwn-e9d65725bdf5954283625ca4d770bfc34f2ae56a.zip | |
lockdep: Fix missing entries in /proc/lock_chains
Two entries are missing in the output of /proc/lock_chains.
One is chains[1]. When lc_next() is called the 1st time,
chains[0] is returned. And when it's called the 2nd time,
chains[2] is returned.
The other missing ons is, when lc_start() is called the 2nd
time, we should start from chains[@pos-1] but not chains[@pos],
because pos == 0 is the header.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <4A88ED25.2040306@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/lockdep_proc.c')
| -rw-r--r-- | kernel/lockdep_proc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/kernel/lockdep_proc.c b/kernel/lockdep_proc.c index 5dbe30b4e591..9a7996e371f5 100644 --- a/kernel/lockdep_proc.c +++ b/kernel/lockdep_proc.c @@ -160,8 +160,8 @@ static void *lc_next(struct seq_file *m, void *v, loff_t *pos) else { chain = v; - if (*pos < nr_lock_chains) - chain = lock_chains + *pos; + if (*pos - 1 < nr_lock_chains) + chain = lock_chains + (*pos - 1); else chain = NULL; } @@ -174,8 +174,8 @@ static void *lc_start(struct seq_file *m, loff_t *pos) if (*pos == 0) return SEQ_START_TOKEN; - if (*pos < nr_lock_chains) - return lock_chains + *pos; + if (*pos - 1 < nr_lock_chains) + return lock_chains + (*pos - 1); return NULL; } |