diff options
| author | Stephen Boyd <swboyd@chromium.org> | 2020-02-06 11:15:21 -0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2020-02-07 21:37:08 +0100 |
| commit | f9f21cea311340f38074ff93a8d89b4a9cae6bcc (patch) | |
| tree | 141cac3361e55e0c64f2d5a9b3e9ef647ee78b0f /kernel/irq | |
| parent | 90568ecf561540fa330511e21fcd823b0c3829c6 (diff) | |
| download | lwn-f9f21cea311340f38074ff93a8d89b4a9cae6bcc.tar.gz lwn-f9f21cea311340f38074ff93a8d89b4a9cae6bcc.zip | |
genirq: Clarify that irq wake state is orthogonal to enable/disable
There's some confusion around if an irq that's disabled with disable_irq()
can still wake the system from sleep states such as "suspend to RAM".
Clarify this in the kernel documentation for irq_set_irq_wake() so that
it's clear that an irq can be disabled and still wake the system if it has
been marked for wakeup.
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lkml.kernel.org/r/20200206191521.94559-1-swboyd@chromium.org
Diffstat (limited to 'kernel/irq')
| -rw-r--r-- | kernel/irq/manage.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 818b2802d3e7..3089a60ea8f9 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -731,6 +731,13 @@ static int set_irq_wake_real(unsigned int irq, unsigned int on) * * Wakeup mode lets this IRQ wake the system from sleep * states like "suspend to RAM". + * + * Note: irq enable/disable state is completely orthogonal + * to the enable/disable state of irq wake. An irq can be + * disabled with disable_irq() and still wake the system as + * long as the irq has wake enabled. If this does not hold, + * then the underlying irq chip and the related driver need + * to be investigated. */ int irq_set_irq_wake(unsigned int irq, unsigned int on) { |