diff options
| author | Zhen Lei <thunder.leizhen@huawei.com> | 2021-08-11 17:33:32 +0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2021-08-11 14:33:35 +0200 |
| commit | 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b (patch) | |
| tree | 7fcdf8ea2d046e1edbc66cc0ce388e908336edd9 /kernel/irq/timings.c | |
| parent | 92848731c45f4f9c3d9818e6b4ba1b2884002324 (diff) | |
| download | lwn-290fdc4b7ef14e33d0e30058042b0e9bfd02b89b.tar.gz lwn-290fdc4b7ef14e33d0e30058042b0e9bfd02b89b.zip | |
genirq/timings: Fix error return code in irq_timings_test_irqs()
Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.
Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com
Diffstat (limited to 'kernel/irq/timings.c')
| -rw-r--r-- | kernel/irq/timings.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index d309d6fbf5bd..59affb3bfdfa 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/timings.c @@ -794,12 +794,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti) __irq_timings_store(irq, irqs, ti->intervals[i]); if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) { + ret = -EBADSLT; pr_err("Failed to store in the circular buffer\n"); goto out; } } if (irqs->count != ti->count) { + ret = -ERANGE; pr_err("Count differs\n"); goto out; } |