diff options
| author | Tommi Rantala <tt.rantala@gmail.com> | 2013-04-13 22:49:14 +0300 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2013-04-15 11:42:12 +0200 |
| commit | 8176cced706b5e5d15887584150764894e94e02f (patch) | |
| tree | 36cce7ca572582944651f686c0de806f1cfe0b0b /kernel/events | |
| parent | 41ef2d5678d83af030125550329b6ae8b74618fa (diff) | |
| download | lwn-8176cced706b5e5d15887584150764894e94e02f.tar.gz lwn-8176cced706b5e5d15887584150764894e94e02f.zip | |
perf: Treat attr.config as u64 in perf_swevent_init()
Trinity discovered that we fail to check all 64 bits of
attr.config passed by user space, resulting to out-of-bounds
access of the perf_swevent_enabled array in
sw_perf_event_destroy().
Introduced in commit b0a873ebb ("perf: Register PMU
implementations").
Signed-off-by: Tommi Rantala <tt.rantala@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: davej@redhat.com
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Link: http://lkml.kernel.org/r/1365882554-30259-1-git-send-email-tt.rantala@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/events')
| -rw-r--r-- | kernel/events/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c index 7e0962ed7f8a..4d3124b39277 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -5331,7 +5331,7 @@ static void sw_perf_event_destroy(struct perf_event *event) static int perf_swevent_init(struct perf_event *event) { - int event_id = event->attr.config; + u64 event_id = event->attr.config; if (event->attr.type != PERF_TYPE_SOFTWARE) return -ENOENT; |