diff options
| author | Randy Dunlap <rdunlap@infradead.org> | 2017-12-08 10:19:23 -0800 |
|---|---|---|
| committer | Jason Wessel <jason.wessel@windriver.com> | 2018-01-25 08:41:14 -0600 |
| commit | b0f73bc7f1793997eb48bd14e3db51c3c95e2098 (patch) | |
| tree | 071edb1dc81c1c3372c56069391d7db16e75ae8e /kernel/debug | |
| parent | 1e0ce03bf142454f38a5fc050bf4fd698d2d36d8 (diff) | |
| download | lwn-b0f73bc7f1793997eb48bd14e3db51c3c95e2098.tar.gz lwn-b0f73bc7f1793997eb48bd14e3db51c3c95e2098.zip | |
kdb: drop newline in unknown command output
When an unknown command is entered, kdb prints "Unknown kdb command:"
and then the unknown text, including the newline character. This
causes the ending single-quote mark to be printed on the next line
by itself, so just change the ending newline character to a null
character (end of string) so that it won't be "printed."
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Diffstat (limited to 'kernel/debug')
| -rw-r--r-- | kernel/debug/kdb/kdb_main.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index ff6047d3b73f..6055231544a0 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel/debug/kdb/kdb_main.c @@ -1150,6 +1150,16 @@ void kdb_set_current_task(struct task_struct *p) kdb_current_regs = NULL; } +static void drop_newline(char *buf) +{ + size_t len = strlen(buf); + + if (len == 0) + return; + if (*(buf + len - 1) == '\n') + *(buf + len - 1) = '\0'; +} + /* * kdb_local - The main code for kdb. This routine is invoked on a * specific processor, it is not global. The main kdb() routine @@ -1327,6 +1337,7 @@ do_full_getstr: cmdptr = cmd_head; diag = kdb_parse(cmdbuf); if (diag == KDB_NOTFOUND) { + drop_newline(cmdbuf); kdb_printf("Unknown kdb command: '%s'\n", cmdbuf); diag = 0; } |