diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-02-17 10:45:25 +0300 |
|---|---|---|
| committer | Daniel Borkmann <daniel@iogearbox.net> | 2021-02-22 18:03:11 +0100 |
| commit | 33ccec5fd740d0d5b78b77846f76eb5b4feb4327 (patch) | |
| tree | 2d7166d78701e201861a45c1892d840cc1ddfe4d /kernel/bpf/verifier.c | |
| parent | b29dd96b905f3dd543f4ca729447286adf934dd6 (diff) | |
| download | lwn-33ccec5fd740d0d5b78b77846f76eb5b4feb4327.tar.gz lwn-33ccec5fd740d0d5b78b77846f76eb5b4feb4327.zip | |
bpf: Fix a warning message in mark_ptr_not_null_reg()
The WARN_ON() argument is a condition, not an error message. So this
code will print a stack trace but will not print the warning message.
Fix that and also change it to only WARN_ONCE().
Fixes: 4ddb74165ae5 ("bpf: Extract nullable reg type conversion into a helper function")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/YCzJlV3hnF%2Ft1Pk4@mwanda
Diffstat (limited to 'kernel/bpf/verifier.c')
| -rw-r--r-- | kernel/bpf/verifier.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 1dda9d81f12c..3d34ba492d46 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -1120,7 +1120,7 @@ static void mark_ptr_not_null_reg(struct bpf_reg_state *reg) reg->type = PTR_TO_RDWR_BUF; break; default: - WARN_ON("unknown nullable register type"); + WARN_ONCE(1, "unknown nullable register type"); } } |